Looks like "Add new search page" form a little bit changed (submit was changed from "Add search page" to "Save"). This is a screenshot: https://www.drupal.org/files/issues/add_new_search_page.png. As a result the EntityCloneSearchPageTest can't be fully passed. We should add simple change to fix it.

The patch is attached.

CommentFileSizeAuthor
#7 some_tests_does_not-2770151-7.patch3.5 KBvpeltot
#5 edit_the-2770151-1.patch1.89 KBvpeltot
entity_clone-search_page_entity_clone_wrong_test.patch675 bytesalan-ps
add_new_search_page.png58.21 KBalan-ps

Comments

alan-ps created an issue. See original summary.

alan-ps’s picture

alan-ps commented
Priority: Normal » Major

change priority to major

AsadKamil’s picture

AsadKamil commented

Patch applied successfully.
Thanks

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community
vpeltot’s picture

vpeltot commented
Title: The EntityCloneSearchPageTest does not passing. » Some Tests does not passing.
Status: Reviewed & tested by the community » Needs review
Issue tags: +alpha blocker
StatusFileSize
new edit_the-2770151-1.patch1.89 KB

The Drupal\entity_clone\Tests\EntityCloneContentTest and the Drupal\entity_clone\Tests\EntityCloneBlockTest fails too (see https://www.drupal.org/pift-ci-job/768377)

Status: Needs review » Needs work

The last submitted patch, 5: edit_the-2770151-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vpeltot’s picture

vpeltot commented
StatusFileSize
new some_tests_does_not-2770151-7.patch3.5 KB
vpeltot’s picture

vpeltot commented
Status: Needs work » Needs review

  • vpeltot committed 3ab5bcc on 8.x-1.x 
    Issue #2770151 by vpeltot, alan-ps: Some Tests does not passing
vpeltot’s picture

vpeltot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.