Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.If a site has unused_modules installed as a module then installing unused_moduhttps://www.drupal.org/node/2755351#les as a drush command and running drush @site unused-modules or drush @sites audit_extensions (if used in conjunction with site_audit as suggested/implemented in https://www.drupal.org/node/2529540) throws a PHP fatal error:
Fatal error: Cannot redeclare _unused_modules_get_modules_by_project() (previously declared in /home/user/.drush/commands/unused_modules/unused_modules.inc:20) in /home/user/projects/sandbox.local/sites/all/modules/unused_modules/unused_modules.inc on line 58
Also, if unused_modules is installed as a drush command, running drush @sites en unused_modules throws the same error.
This is bad for people who might want to use unused_modules as a drush command in platforms where you can't know in advance whether sites have unused_modules installed already.
- unused_modules versions tested (as drush command): 7.x-1.5 and 7.x-1.x-dev
- unused_modules versions tested (as site module): 7.x-1.5
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | unused_modules-drush_include_files-2755351-4-D7.patch | 1.29 KB | erickbj |
Comments
Comment #2
ndf commentedFor UI the module must be installed in the installation off-course, but yeah I can understand that you would like to install this in
.drushtoo.I don't have an idea how to solve this in the module though. In PHP you cannot redeclare a function twice:
source: http://php.net/manual/en/functions.user-defined.php
So in this case I think you must choose; enable the module in the site or only in
.drush.Please re-open if you see this different!
Comment #3
ndf commentedThere is a site I worked on that has the described setup with registry-rebuild. The registry-rebuild module is installed both in
.drushand in thesites/all/modules. And the drush command works as expected.So it must be possible for this module too.
Comment #4
erickbj commentedChecking out the latest version for registry_rebuild I don't see how that could be enabled as a module (there's no .module or .info files in the package). There's only registry_rebuild.drush.inc and the "site" version of that file (i.e., what is put into sites/all/modules or similar path) is never used when registry_rebuild is installed as a drush command/extension too. I might be mistaken but I think that's why having RR both installed as a drush command/extension and site module doesn't break things.
Regarding unused_modules I think for now it'd be a matter of avoiding including unused_modules.inc more than once - the attached patch does exactly that. We can't trust require_once to avoid this inclusion more than once because files paths (from the drush installed version to the site installed version) will vary in most cases.
Comment #5
erickbj commentedChanging status to "needs review".
Comment #7
ricardo.peressinotti commentedI tested the patch but the issue still happening.
Comment #8
ricardo.peressinotti commentedIn my last test I forgot to apply the patch in the drush command folder, I applyed only on site module folder.
Now I did the test applying the patch for both folders (drush command and site module). Everthing is working correctely.
Don't forget to apply the path in both folders (~/.drush/commands and ../sites/all/modules/unused_modules)! It's realy important to do this!
Check my terminal messages:
Thanks @erickbj
Comment #9
ricardo.peressinotti commentedChanging status to "needs review".
Comment #10
ricardo.peressinotti commentedThe patch is working! :)
For more information, please check the comment #8.
Thanks @erickbj
Comment #12
larruda commentedI've contacted @ndf and he committed the patch!
Comment #14
ndf commentedIt's in stable now: 7.x-1.6
https://www.drupal.org/project/unused_modules/releases/7.x-1.6