Problem/Motivation

The current 8.x port uses config entities for the HTML templates. A co-worker of mine is working on a submodule to this that would use content entities. The advantage of config entities is that they are readily deployable via git (eg, CMI). The disadvantage is they cannot use some of the more advanced features of the content entity system such as bundles (eg, categories of templates), and permissions around CRUD operations.

Proposed resolution

Split the core functionality of this module into a base module (wysiwyg_template_core perhaps), have wysiwyg_template depend on the new module, and then in the near future, add wysiwyg_template_content module that would support templates that are content-entity-based.

Remaining tasks

Review, discuss.

User interface changes

None for now.

API changes

Data model changes

CommentFileSizeAuthor
#5 consider_supporting-2735305-5.patch1.23 KBdavid.gil
#4 2735305-04.patch9.09 KBjhedstrom
#4 interdiff.txt7.18 KBjhedstrom
#2 2735305-02.patch7.66 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Category: Plan » Task
Status: Active » Needs review
StatusFileSize
new 2735305-02.patch7.66 KB

Not ready for merge yet, put a proof-of-concept.

Additional functionality that would be common to both config and content based templates:

  • The CKEDitor plugin definition
  • The ability to select a default content template for content types
  • ...

Status: Needs review » Needs work

The last submitted patch, 2: 2735305-02.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Assigned: jurgenhaas » jhedstrom
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt7.18 KB
new 2735305-04.patch9.09 KB

This additionally moves the interface into the common core module, as it will be used both by the config-based entity, and the content-based entity.

david.gil’s picture

david.gil commented
StatusFileSize
new consider_supporting-2735305-5.patch1.23 KB

Send again to test bot

david.gil’s picture

david.gil commented

ups sorry last patch no correspond to this issue

  • jurgenhaas committed 85bf505 on 8.x-2.x 
    Issue #2735305 by jhedstrom, jurgenhaas: Consider supporting both config...
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Fixed

Reviewed and pushed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.