Problem/Motivation

Having the LogEntry save itself makes injection more complicated and requires additional classes for each logger.

Proposed resolution

Move save() to the plugin, properly inject dependencies.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 ultimate-cron-log-entry-save-2731683-2.patch14.68 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new ultimate-cron-log-entry-save-2731683-2.patch14.68 KB

This moves the save method, had to rename create() to createEntry() so that injection can use the create() method.

  • Berdir committed 9b5bbec on 8.x-2.x 
    Issue #2731683 by Berdir: LogEntry::save() should move to LoggerPlugin
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

And committed this as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.