Problem/Motivation

What the title says.

Proposed resolution

Save after adding to spool.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 simplenews-scheduler-2723151-5.patch1.2 KBtduong
#5 simplenews-scheduler-2723151-5-test_only.patch716 bytestduong
#4 simplenews-scheduler-2723151-4.patch2.38 KBtduong
#4 simplenews-scheduler-2723151-4-test_only.patch1.87 KBtduong
#2 simplenews-scheduler-2723151-2.patch517 bytesberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new simplenews-scheduler-2723151-2.patch517 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
Issue tags: +Needs tests
tduong’s picture

tduong commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new simplenews-scheduler-2723151-4-test_only.patch1.87 KB
new simplenews-scheduler-2723151-4.patch2.38 KB

Added test checking that "simplenews_scheduler" table has been updated after sending a newsletter edition.
Test_only = interdiff. I cannot make it to fail

tduong’s picture

tduong commented
StatusFileSize
new simplenews-scheduler-2723151-5-test_only.patch716 bytes
new simplenews-scheduler-2723151-5.patch1.2 KB

Moved the test into SimplenewsSchedulerNodeCreationTest and checked for the $edition_node->simplenews_issue->subscriber count instead of what I did before. (interdiff longer than patch).

The last submitted patch, 5: simplenews-scheduler-2723151-5-test_only.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Works for me.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committd, thx!

  • miro_dietiker committed cec1a70 on 8.x-1.x authored by tduong 
    Issue #2723151 by tduong, Berdir: Scheduled editions are not saved after...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.