It doesn't seem to me that validation for the admin settings form (admin/store/settings/payment/method/credit) is necessary when uc_stripe is not enabled (Enable this payment gateway for use.). This patch skips validation when that checkbox is not checked.

CommentFileSizeAuthor
uc_stripe-validation.patch1.22 KBjacob.embree

Comments

jacob.embree created an issue. See original summary.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Thanks for the patch, and this does seem reasonable. I'll try to test and validate the approach next time I'm in there. Anybody else is welcome to review it of course.

  • rfay committed 6e304f8 on 7.x-2.x authored by jacob.embree 
    Issue #2698713 by jacob.embree: Admin settings validation tougher than...
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

This looked like the best approach to me. Committed. Thanks so much, @jacob.embree

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.