Form mismatch loses order setting in Workbench Transitions

I put this in the 1.01 sprint: #2698181: [META] Lightning 8.x-1.01 but I suspect we can quickly fix this post RC1 and get it into whatever the next release turns out to be. At a minimum, I suspect we can provide a patch for this next week.

Thanks!

Moved to RC3 sprint. And I started referencing the issues included in sprints. So you should see the sprint issue in the sidebar now.

Ah - lightning actually isn't touching that form (I thought it was).

Digging a little deeper, it looks like the form at /admin/structure/workbench-moderation/transitions only goes from ±10. But that number is increased when the number of total transitions is greater than 20. At that point, editing an individual transition that has its weight set to >10 or <-10 will result in it being reset to 10/-10.

First off, what are you people doing that you have more than 20 transitions???

The issue here is that the draggable list weight field is automatic, and always uses negative numbers up to the number of items, so it scales for any number of items. The translation edit form uses the normal weight form element, whose default delta is 10.

The attached patch makes the transition edit form's delta dynamic as well.

Manually tested an confirmed. I created [a ton] of moderations state transitions, dragged one to the top of the list, then clicked "show row weights" and confirmed that the first transition's weight was -12 (as expected). After applying the patch, the edit form for that transition displays -12 as well.

Thanks!

Spiffy. Merged!