Move all vote related methods from PollStorage to the new poll_vote.storage service

1. +++ b/src/Entity/Poll.php
   @@ -379,7 +379,8 @@ class Poll extends ContentEntityBase implements PollInterface {
   -    $poll_storage_controller = \Drupal::entityManager()->getStorage('poll');
   +    /** @var \Drupal\poll\PollVoteStorage $poll_storage_controller */
   +    $poll_storage_controller = \Drupal::service('poll_vote.storage');
        return $poll_storage_controller->getUserVote($this);
   

   You should update the variable name. it's no longer a storage_controller. Just $vote_storage.

2. +++ b/src/PollStorageInterface.php
   @@ -16,61 +15,6 @@ use Drupal\Core\Session\AccountInterface;
   -   * Save a user's vote.
   -   *
   -   * @param array $options
   -   *
   -   * @return mixed
   -   */
   -  public function saveVote(array $options);
   

   Poll has a beta release. That means we should not change the API like this, it might break custom and other contrib modules.

   So what we have to do is add a @deprecated text, see examples in core and say that this was deprecated in 8.x-1.0 and XYZ should be used instead. Then also keep the old implementations and call the new methods instead.

3. +++ b/src/PollVoteStorage.php
   @@ -2,17 +2,19 @@
   -class PollVoteStorage implements PollVoteStorageInterface {
   +class PollVoteStorage extends SqlContentEntityStorage implements PollVoteStorageInterface {
   

   this is not an entity storage. Don't extend from that.

4. +++ b/src/PollVoteStorageInterface.php
   @@ -2,15 +2,18 @@
   -interface PollVoteStorageInterface {
   +interface PollVoteStorageInterface extends EntityStorageInterface {
    
   

   same here. we just have our own methods, nothing else.

+++ b/src/Plugin/views/field/PollTotalVotes.php
@@ -23,8 +23,9 @@ class PollTotalVotes extends FieldPluginBase {
     $entity = $values->_entity;
-    return  $pollStorage->getTotalVotes($entity);
+    return  $vote_storage->getTotalVotes($entity);

double space here, lets fix it while we touch the code.

I'll fix that on commit.

Thank you.