#2469431-230: BigPipe for auth users: first send+render the cheap parts of the page, then the expensive parts added a RouteMatchInterface argument to the BigPipeStrategy constructor. This was not added to the BigPipeDemoStrategy constructor at that time, so enabling this module against D8.1 HEAD causes WSODs

[Sat Mar 05 17:23:01.480569 2016] [:error] [pid 10078] [client 127.0.0.1:51229] Recoverable fatal error: Argument 3 passed to Drupal\\big_pipe\\Render\\Placeholder\\BigPipeStrategy::__construct() must implement interface Drupal\\Core\\Routing\\RouteMatchInterface, none given, called in big_pipe_demo/src/Render/Placeholder/BigPipeDemoStrategy.php on line 44 and defined in core/modules/big_pipe/src/Render/Placeholder/BigPipeStrategy.php on line 103

Comments

mr.baileys created an issue. See original summary.

pol’s picture

Status: Needs review » Reviewed & tested by the community

Patch is working fine.

Thanks.

wim leers’s picture

Reproduced.

wim leers’s picture

StatusFileSize
new2.13 KB
new866 bytes

Nit: the constructor's code was updated, but not its docblock.

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • Wim Leers committed ae83c0b on 8.x-1.x authored by mr.baileys
    Issue #2681727 by mr.baileys, Wim Leers: BigPipe Demo broken against D8....
wim leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.