Per https://github.com/Modernizr/grunt-modernizr/issues/118#issuecomment-140..., that path has been removed since 3.0, and won't be re-added. Therefore there's no longer a "default" build of Modernizr.
I suppose there's 2 options moving forward-
- Define a "default" build of Modernizr, and update drush modernizr-dev to utilize it.
- Remove the modernizr-dev command.
Please let me know the preferred direction, and I'll be happy to submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | remove_dev_option-2670574-7.patch | 4.18 KB | albert volkman |
Comments
Comment #2
ruplWell snap. 5 months ago when I released the hacked-together workaround for v3 they hadn't removed the file yet. I've been traveling since then..
This might have surfaced sooner if it wasn't 200ing the empty file. Would be nice if it were 404 or 410. I've asked the Modernizr folks if it's possible to modify the URL to report the proper status code.
In terms of what the module should do, I'd say go with option 2: remove the
modernizr-devdrush command. This has ramifications beyond the module code itself (have to update docs, project page instructions, etc) but whatever. I'll fix it all up in April at the latest when I am back home.For now I'm in the middle of SE Asia and often find myself in areas not offering fast internet access, so if you write a patch please forgive my delayed review.
Comment #3
albert volkman commentedComment #4
ruplHey actually I realized we should probably leave the actual command in place, but have it produce a deprecation notice. That way we won't have to update all the docs immediately and people will understand that something has changed in cases where they might have embedded this command into a script or something.
Comment #5
albert volkman commentedI don't follow... as it stands, it'll download a blank file. If we simply add a deprecation notice, I'm assuming a lot of people will overlook that, merge the blank library, and then wonder why it's not working.
Comment #6
ruplI mean instead of deleting the command completely, the drush command could be modified to no longer fetch the file, instead immediately returning a Drupal Error. The error would report that the library file is permanently unavailable. The command description could also be changed to say "This command used to download a development copy of Modernizr but it is no longer offered on modernizr.com as of v3"
Comment #7
albert volkman commentedHow about this?
Comment #8
ruplNice catch on this rewording of the requirements! I tested this and it seems good to me. I'll merge and cut a new version of the module.
Side note: the URL now reports a 404 and the contents are a message about the file being deprecated. This will help the users who aren't yet using the new version of the module.
Comment #9
ruplNew release (7.x-3.8) — https://www.drupal.org/node/2677048
Comment #10
albert volkman commentedGreat! Nice work upstream as well :)
Comment #11
albert volkman commentedOh, you might want to check out the project page as well. Current text reads-
Comment #13
ruplah thanks for the reminder, I edited the page