Replace deprecated usage of drupal_render with a theme_render_and_autoescape.

CommentFileSizeAuthor
#9 linkicon-replace-drupal-render-2662424.patch2.74 KBgausarts
#2 2662424-2.patch1.05 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2662424-2.patch1.05 KB
gausarts’s picture

gausarts commented

Thanks. Just for reference:
https://www.drupal.org/node/2576881
https://www.drupal.org/node/2575445

gausarts’s picture

gausarts commented
Status: Needs review » Needs work

Please also remove those TODOs mentioned above any of the updated code. Thanks.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review

@gausarts, Currenlty i don't see any other depreciated methods in the code base.

gausarts’s picture

gausarts commented

Sorry for not being clear, I meant those lines saying:
// @todo #2575445 theme_render_and_autoescape()

gausarts’s picture

gausarts commented
Status: Needs review » Needs work

This seems is going to be deprecated as well here ;)

gausarts’s picture

gausarts commented
Title: Replace deprecated usage of drupal_render with a theme_render_and_autoescape. » Replace deprecated usage of drupal_render with renderer
Status: Needs work » Needs review
StatusFileSize
new linkicon-replace-drupal-render-2662424.patch2.74 KB

Let's fix this with the more future-proof replacement.

  • gausarts committed f838c64 on 8.x-1.x 
    - #2662424 by heykarthikwithu, gausarts: Replace deprecated usage of...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Committed. Thank you for contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.