Rename 'event' parameter in userpoints_userpointsapi() to 'operation'

Actually, the README.txt for the API still documents the name of the parameter as 'event', although the database column is called 'operation'.

So the module is doing the right thing.

However, for consistency, we may want to rename the parameter event to operation in a future API overhaul.

Thus moving to Userpoints API project.

Changing the title to be more descriptive.

Kiam

Did you read the README.txt document before changing the issue back?

Go and read here under "API".

It says:

'event' => (string) varchar32 descriptive identifier administrative purposes

So, the parameter name is still event, not operation. This is why it needs to change in Userpoints API, before the other modules can be changed.

I think we are both right, and both wrong too.

userpoints_userpointapi() has this:

/**
 * @param $params(array) or (int)
 *    if (int) assumed to be points for current user
 *    Accepts an array of keyed variables and parameters
 *    'points' => # of points (int) (required)
 *    'moderate' => TRUE/FALSE
 *    'uid' => $user->uid
 *    'operation' => 'published' 'moderated' etc.

And the code has 'operation' everywhere.

However, there is just one place that still has 'event', here:

  // Call the _userpoints hook, and stop if one of them returns FALSE
  $rc = module_invoke_all('userpoints', 'points before', $params['points'], $account->uid, $params['event']);

I am attaching a patch for 5.x-3.x that would make it all "operation" instead of the old "event".

If you and jredding can review this patch and see if it does not break anything, then I will commit it, then I will do a wholesale change for the userpoints_contrib as well, with one issue (since the change is the same for all modules).

We also need to port this patch to 6.x later.

The parallel issue for userpoints_contrib is here http://drupal.org/node/265764

Review of both patches needed.

@jredding

Can you eye over this one please?

The hook should've also been called operation and not event and an eyeball over the patch looks OK.

The change doesn't affect any existing code so I suggest we put it straight into 5.3.6 and roll a new release.