Problem/Motivation

It looks like we have two keys in the features bundle entity type that are no longer used:

  • 'settings': perhaps once stored what's now in features.settings simple configuration?
  • 'weights': now stored with the individual assignment plugins

Proposed resolution

Remove.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 2653124-6.patch2.12 KBnedjo
#2 2653124-2.patch1.38 KBnedjo

Comments

nedjo created an issue. See original summary.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2653124-2.patch1.38 KB
naveenvalecha’s picture

naveenvalecha
He/Him
commented

I believe We also have weights metadata left in \Drupal\features\Entity\FeaturesBundle and $weights property

  • nedjo committed a188dcb on 8.x-3.x 
    Issue #2653124 by nedjo, naveenvalecha: Remove obsolete 'settings' and '...
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

@naveenvalecha: thanks for noting that. I removed the $weights and $settings properties from \Drupal\features\Entity\FeaturesBundle.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Fixed » Needs review
StatusFileSize
new 2653124-6.patch2.12 KB

We have a failing test caused by the commit in this issue.

Looks like there's more obsolete code that I missed. Patch attached.

  • nedjo committed 46e9d73 on 
    Issue #2653124 by nedjo: Remove obsolete code missed in previous cleanup...
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Committed this to get tests working again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

carsonblack’s picture

carsonblack commented

Just a note on this: In 8.x-3.0-alpha6 this patch applies cleanly and it also fixes an issue where dependencies are not being correctly identified and written to the .info.yml file.