Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Add a Open jobs option to display just the options that need to work on. The closed ones should not appear since it will be better for the users to filter them.
The 'Open Jobs' option should be selected by default.
We can take as Open Jobs the following states:
- STATE_UNPROCESSED
- STATE_ACTIVE
- STATE_REJECTED
Add test cases.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | add_open_jobs_option-2650776-6.patch | 4.57 KB | johnchque |
| #6 | interdiff-2650776-3-6.txt | 951 bytes | johnchque |
| #3 | Screenshot from 2016-01-18 15:56:28.png | 13.62 KB | johnchque |
| #3 | add_open_jobs_option-2650776-3.patch | 4.2 KB | johnchque |
Comments
Comment #2
miro_dietikerAdding a note here:
REJECTED is open because it was rejected by a translator. Thus i need to be aware of it and can resubmit it.
However, i don't know of any real case of this... and i'm also not so sure if it is properly covered at all with the remote job mapping that is then reused and might result in overlaps. If i remember right, then we defined that resubmitting a job can only happen through cloning it and that finally again leads to a problem that we need to close a rejected job to make it go away from the open ones. So this whole discussion needs a followup to investigate and improve. ;-)
Comment #3
johnchqueAdded Open jobs option being selected by default. Added test cases. Still need to decide how to manage a resubmitting jobs.
Comment #4
berdirWondering if it should just be Open, considering that we don't use "jobs" anywhere else in the states, not sure?
Also, this just seems to update the existing test coverage. What I'd like to see now is an explicit test that makes sure that we do *not* see non-open jobs by default. Should be easy enough, you already fix a test to make sure a certain job still shows up by using a specific filter. Just do another request and make sure it's not shown if you don't select any option for state.
Comment #5
miro_dietikerYeah that's important. I've checked some of the TMGMT lists (e.g. the local translator) where the filters don't work as expected and unexpected items are still not filtered...
Comment #6
johnchqueAdded test cases and changed the option to '- Open Jobs -'. If we are following the design of drupal.org website when we look for issues it says '- Open issues -' so I think it is Ok to keep it like '- Open Jobs -'. Interdiff added.
Comment #7
berdirLooks good. Not a crucial thing, so fine if existing sites don't have this.