[page-title] can be wrongly replaced depending on whether and when token_replace() is executed by any other module.

I misstyped the proper formatting for the link to the bug reported on my module, adding it here: #264187: Interfering with page_title module?

Well, I first thought that it was a token module problem as well, but then I don't think that caching is a bad idea, and as they give developers a chance to flush the cache and in the case of your module I believe that flushing it before replacing the actual token is a proper way of using the token module.

Just a thought.

Thanks,
Ariel.=

It certainly was... sorry.. here's the proper one

By following another reported conflict on my module with this one #276355: Losing my Page Title and Tabs when adding tags on nodetypes I detected another issue that led me to a patch on this module. Now, in this case, is a very strange thing. I will try to explain in the best way I can. It's not a real 'bug' of this module but a chain of things triggered by my module, although there's nothing I can really do about it on my own.

The actual problem is that the tabs are disappearing if both my module and page_title are enabled.

If drupal_get_title() gets executed in the hook_menu() of any module, tabs will disappear because of some internal core menu.inc function.

Does page_title do this? Well, not directly, but it does indirectly.

My module relies on a nodewords hook where I do a bunch of token replacements. That hook is invoked on the nodeworkds_menu hook, where I trigger some token replacements. Those token replacements also trigger the token hooks on all installed modules (such as page_title) which eventually executes drupal_get_title(), triggering the tabs disappearing problem.

The best fix I found, which is a design decision for the maintainers of this module was to use a slightly different approach for retrieving the current page title.

By looking at the actual code of drupal_get_title() I noticed it does two things, first it retrieves the stored title, and if it's null, executes the actual conflicting function. As I see the logic of this module, when the function is run there will definitely be a stored title within drupal internals, so I think this is a reliable fix, or better say, change for this module.

I hope it's clear.

I am attaching a new patch that includes the two fixes mentioned on this issue.

My module is Meta Tags Node Type and no, I am not saying exactly that.

In the issue I mentioned on #7 it was reported that the node tabs (VIEW/EDIT, etc) were disappearing if both modules were enabled.

Following that issue I found this drupal_get_title() issue. If you add drupal_get_title() just for testing in your hook_menu() function you should notice this tabs disappearing issue, even without my module enabled at all.

My module depends on a nodewords hook. That hook is invoked in nodewords_menu() hook. The nodewords hook on my module calls to token_replace() to perform some token replacements and that function invokes the token hooks on your module which eventually calls drupal_get_title().

drupal_set_title to get the title only works if a call has been made to it to override the callback title. If it hasn't then Drupal falls back to the menu system to ask the menu system what the callback title is...

It's the actual menu fallback function that triggers this tabs disappearing problem. My suggestion of using drupal_set_title() instead was to avoid calling to that function, but now you put it that way, it makes sense to think that if no previously drupal_set_title() was made you MUST fall back to the menu system function, thus drupal_get_title() is the function that should be used.

The problem I am facing is that I can't do anything about it on my side because IT IS the drupal_get_title() of page_title module that's triggering the problem, although triggered because it ends up being called from a hook_menu() hook through my module.

I will have to think of another solution, I already have one on my mind but I it's not very clean as well. I want to hear your thoughts first though. Did this post make things clear?

Thank you very much for replying,
a.=

It might be a bug for the drupal core, I would have to check this on newer versions and see if it worth a posts, I do believe as well that that shouldn't be a function that conflicts in anyway with drupal's logic.

However it's going to be definitely faster to try and find a workaround on your module and hope that you'll like it.

I'll probably post soon with more thoguhts.

Hi Nicholas,

I spent some more time looking at this, it's really an annoying issue and I think I have come up with another solution that might be a lot better. I agree with you that drupal_set_title() is not the way to go.

Now I am attaching another patch. This patch actually fixes this issue as well as the first one posted in this thread but you don't need to flush the token's cache anymore.

The idea behind this patch is not to define your token replacements withing the token global scope. As your replacement should happen on a very specific moment (when run through the template.php hook) and considering that having it in the global may lead to this problem if my or any other module somehow triggers token replacements within the hook_menu of that module, I am defining a new token scope just for your module (page_title).

In this way, it's just your module or, if needed, any other module that needs to trigger your replacements can use this scope as well. I modified the lines wehre you called token_replace() function.

I believe this one is a better/cleaner fix and still respects the logic on your module.

I am probably going to use this module pretty soon so interested in getting this fixed as well :)

Thanks!
a.=

I believe I have to bring this issue back to life. Even after a while of upgrading the module I wasn't aware of this until recently where I noticed that the page_title on all my nodes read "Content" as also reported on #565542: Either "Content" or menu item title or a blank empty string swaps in for [page-title] token, after upgrading.

I noticed that what this patch, which was committed on alpha-6 attempted to fix was indeed happening again. By looking at the code and the CVS I noticed that somehow, the change provided by this patch was lost in Revision 1.12.2.21 of page_title.module. Funny I just noticed it now.

Attached is a patch for latest page_title version, and I think it should be applied in D6 branch as well, not sure if it'd apply clean, but I'd think so.

Hopefully you can go over the full extent of this issue as a reminder of what was happening, as same things are happening again.

Just upgraded to 2.3 and w/o my patch on #21, page-title seems to be fine now. I still consider the what the patch does to be a better practice for tokens, so probably worth a review. At least, it was accepted once.