Hi,
Thanks for this wanted add on to nodewords.
I have the page_title module installed and on a certain contenttype I set the token: [term-raw]. The first term will then be selected and put in my pagetitle which is ok.
After patching nodewords and installing this module and also putting the token [term-raw] in the field on contenttype, the pagetitle doesn's show the correct values anymore, but shows the word "content" instead of the term.
Is this clear? Does it make sense?
Thanks in advance for going into this!
Greeting,
Martijn

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Assigned: Unassigned » hanoii

Sorry, I didn't follow you.

I tried to do what I understood, which was installing page_title (what version are you using? - I installed the latest 2.0-alpha) and did what you explained and I saw no conflict. Thinking it ahead it shouldn't conflict which each other but if you can give me more details in order to reproduce this error I can look it up better. When you say that you also put the token [term-raw] in the field on contenttype, what did you mean?

Thanks,
Ariel.=

summit’s picture

summit commented

Hi Ariel,

I did the following. I filled in on page_title on my contenttype: [title][term-raw]
And did the same through your module. I added [term-raw]
Without [term-raw] through your module. The page title was nicely title and first term
After using your module the title only showed Content instead of the title on the tag.
Is it clear like this?

If you would like to email further or chat on google chat tomorrow, ok by me.

greetings,
Martijn

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

And did the same through your module. I added [term-raw]
Without [term-raw] through your module. The page title was nicely title and first term

This is the part I don't understand. You added [term-raw] exactly where on my module? The keywords field, they description field, and on which drupal path?

summit’s picture

summit commented

Hi, Sorry for not being accurate. I try to be as accurate as possible underneath:

On: admin/content/types/my_contenttype I added [term-raw] on:

Default "keywords" meta tag: 
[term-raw]

Default "description" meta tag: 
[term-raw]

For page_title (page_title 2.* dev) I placed on the tokenplace in for my contenttype on /admin/content/page_title:

[page-title] | [site-name] | [term-raw]

Now without placing [term-raw] in or keyword and/or description field using your module the page-title itself comes up but when I fill in [term-raw] in or keywords or description field on admin/content/types/my_contenttype

The page-title is not shown, only the word "Content" in my first part of my title tag.
So my complete title tag is Content | Correct site-name | Correct term. So somehow my [page-title] token is interfered...

Hope this is valuable information to get this solved!
greetings,
Martijn

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Closed (won't fix)

Summit, thank you for taking the time to answer all my questions.

Your last post was very helpful and I was able to reproduce the problem. However, I believe it's not a problem on my module but rather on page_title. I have posted an issue with a patch that fixes this problem. #264662: [page-title] can be wrongly replaced depending on whether and when token_replace() is executed by any other module..

Also to add more information to this issue, there was not really a problem of having [term-raw] in my module' settings or not, but just any other text there would trigger the problem as I will execute token_replace() and that lead to the problem.

As a quick fix for you I can suggest you two things:

1. Apply the patch I submitted in the issue I mentioned above.
2. Try the [title] token, instead of [page-title] which may give you similar results without this problem. (Not really sure about this).

Thanks, it was a time-consuming but interesting issue to follow.

summit’s picture

summit commented

Hi Ariel,

You patched the file the other way around on page_title, see my comment there.
Thanks for going into this. It looks working!!
Please file the correct patch on page_title so it can go in on 2.dev.

greetings,
Martijn

EvanDonovan’s picture

EvanDonovan commented

See the patch in #14 of #264662: [page-title] can be wrongly replaced depending on whether and when token_replace() is executed by any other module., which is a cleaner patch from hanoii to the Page_title module.