If a number has already been confirmed,
clicking "Delete & Start Over" nothing happens.

I propose this change:
file sms_user.module line 273,
replace

$output['opt_out_form'] = drupal_get_form('sms_user_opt_out_form', $account);

with

$output2 = Array();
$output2['mobileform'] = $output;
$output2['opt_out_form'] = drupal_get_form('sms_user_opt_out_form', $account);
$output = $output2;
CommentFileSizeAuthor
#4 2645952-4-fail.patch3.5 KBalmaudoh
#2 2645952-fail.patch478 bytesalmaudoh

Comments

diego.paroni created an issue. See original summary.

almaudoh’s picture

almaudoh commented
Status: Active » Needs review
StatusFileSize
new 2645952-fail.patch478 bytes

Tweaked the SMS opt out test to expose this bug. Let's see if this patch fails.

almaudoh’s picture

almaudoh commented

The test obviously didn't work. I have been able to manually replicate this bug, sleep_time needs to be disabled while opt_out is enabled in the global SMS user settings to have this bug.

However, a Drupal web test that replicates those same conditions doesn't fail. I may have to fix this without the test.

almaudoh’s picture

almaudoh commented
StatusFileSize
new 2645952-4-fail.patch3.5 KB

Trying to get a failing test patch

almaudoh’s picture

almaudoh commented

As we don't have BrowserTests on D7 and I'm unable to reproduce this bug in a test using WebtestBase (I have reproduced manually), I'll go ahead to commit the fix without the test, but will leave the issue open for a while.

  • almaudoh committed 2343425 on 7.x-1.x 
    Issue #2645952 by almaudoh, diego.paroni: Delete...
almaudoh’s picture

almaudoh commented
Status: Needs review » Fixed

Consider this fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.