Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Use of drupal_realpath is not recommended. Fails to process for remote schemas, and get the following errors
exif_read_data(): Filename cannot be empty in exif_custom_get_exif_fields()
etc
Suggest changing to file_create_url. I'll submit a patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | exif_custom-n2643818-10.patch | 1.06 KB | damienmckenna |
| #2 | exif_custom-change_drupal_realpath_function-2643818-2-7.patch | 1.03 KB | michaelmallett |
Comments
Comment #2
michaelmallett commentedComment #4
michaelmallett commentedThe dispatcher says that this patch failed due to no tests being specified, can anyone help with getting that sorted? Patch should be fine, is there something else I'm supposed to do?
Comment #5
leon kessler commentedThis patch breaks when you upload a file to create the new mapping (as this uses the temporary file schema, which does not work with file_create_url())
Comment #6
michaelmallett commentedRemind me, this was because file_create_url can't create a url from temp:// ?
Comment #7
leon kessler commentedYep it wasn't working when you uploaded a new mapping.
Although it look like the temporary file schema does support external urls (https://api.drupal.org/api/drupal/includes%21stream_wrappers.inc/functio...)
But I don't think they were resolving properly.
Comment #8
joseph.olstadComment #10
damienmckennaRerolled.
Comment #11
damienmckennaComment #13
damienmckennaCommitted. Thanks.
Comment #14
damienmckennaFYI I had to add an option to use the old method as it caused problems, see #2928054: Add back support for drupal_realpath() for sites with complicated setups.
Comment #15
joseph.olstadas per comment #5 this patch causes:
#2929232: Can't upload example image
Comment #16
joseph.olstadReviewing the regression.
Comment #17
damienmckennaPlease see #2928054: Add back support for drupal_realpath() for sites with complicated setups.
Comment #18
joseph.olstadstill doesn't work for me, either option fails.
same error.
Also, there's a type-o on line 657
$size = @getimagesize($image_url, $info);should be:
$size = getimagesize($image_url, $info);however, same issue either way.
still trying to figure this out
Comment #19
joseph.olstadsorry ya my bad, this is good here, followup in #2929232: Can't upload example image