I have noticed the viewport meta tag is included by default with this module. Now I understand it is documented in the module about maybe removing this and have themes manage the viewport tag, and that many in fact do not.

Unfortunately some themes are hard-coding the viewport tag right in the html.tpl.php template, such as Zen. This makes it impossible to check for the viewport tag in preprocess and process functions, or even the template_html_head_alter() function. Otherwise we could simply search for it and choose whether to include it with Adminimal Administration Menu.

Perhaps the best option would be including a module setting to add the viewport tag? A decision to be made, tell me if you agree/disagree on this, would be whether to include the viewport tag by default. The administration menu does become rather unusable on smaller devices without it, so being added by default seems sensible to me. Then those who want to disable it can easily do so on the current module's configuration page.

I set this to a support request since the module already includes the viewport tag, but also because I want to open it up to discussion before it is considered as a feature request.

CommentFileSizeAuthor
viewport-meta-tag.png17.13 KBRichard Buchanan

Comments

Richard Buchanan created an issue. See original summary.

valderama’s picture

I would suggest to remove the viewport statement for the module and let themes handle it.

szy’s picture

I can see double menu with Adminimal Theme now. Fresh 7.x installation.

Szy.

tessa bakker’s picture

Version: 7.x-1.7 » 7.x-1.x-dev
Category: Support request » Bug report

The viewport needs to be removed, this is a theme thing and also an accessibility issue, users can't zoom in.

  • Tessa Bakker committed 8392f00 on 7.x-1.x
    Issue #2640776: Allow viewport to be disabled with a variable.
    
tessa bakker’s picture

Status: Active » Needs work

A setting to disable/enable the viewport is needed.

  • Tessa Bakker committed f24fa1e on 7.x-1.x
    Issue #2640776: Viewport variable as setting in config
    
tessa bakker’s picture

Status: Needs work » Fixed

Can be disabled now on the configuration page.

tessa bakker’s picture

Status: Fixed » Closed (fixed)