WSOD caused by 'description' as array

A looked into this a just removing the cardinality check works for me. Tested it out with different cardinality settings. So wanted to make a test coverage too but then i got some schema errors:

[01-Apr-2016 20:21:17 Australia/Sydney] Uncaught PHP Exception Drupal\Core\Config\Schema\SchemaIncompleteException: "Schema errors for field.field.node.page.field_name_test with the following errors: field.field.node.page.field_name_test:default_value.0.title missing schema, field.field.node.page.field_name_test:default_value.0.given missing schema, field.field.node.page.field_name_test:default_value.0.middle missing schema, field.field.node.page.field_name_test:default_value.0.family missing schema, field.field.node.page.field_name_test:default_value.0.generational missing schema, field.field.node.page.field_name_test:default_value.0.credentials missing schema" at /var/www/html/d8/core/lib/Drupal/Core/Config/Testing/ConfigSchemaChecker.php line 98

looks like a followup to me.

Without the check is the description repeated on every element? I think that was the reason for this check.

If not, all good, if so then (without doing any D8 programming yet) isn't $field simply an object, so $field->getCardinalityOrWhateverTheFunctionIsCalled() should work?

By manual testing no duplicate without the check. So all fine :)

the obj is Drupal\name\Plugin\Field\FieldWidget\NameWidget i will have to see how to best get the cardinality.

Cool, but quick clean up maybe.

Late here, but thinking that with this change all we are left with is if the element has a description, render that afterwards if it is a Name Element (as opposed to a Field Widget).

  if (!empty($element['#description'])) {
    $field = isset($element['#field']) ? $element['#field'] : NULL;
    if (!$field || $field['cardinality'] != 1) {
      $element['_description'] = array(
        '#value' => '<div class="clearfix description">' . $element['#description'] . '</div>',
      );
      unset($element['#description']);
    }
  }

  if (!empty($element['#description']) && !isset($element['#field'])) {
    $element['_description'] = array(
      '#value' => '<div class="clearfix description">' . $element['#description'] . '</div>',
    );
    unset($element['#description']);
  }

Luckily this saves bridging into the field storage definition; actually a bit surprised you have to do something like this:

class NameWidget {
  public function isMultiple() {
    // For any multiple element
    return $this->fieldDefinition->getFieldStorageDefinition()->isMultiple();
    // or maybe only applicable for those with Add another enabled....
    $cardinality = $this->fieldDefinition->getFieldStorageDefinition()->getCardinality();
    return $cardinality == FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED;
  }
}

Done the cleanup, also improved test to check that the description is unique.

Still remains to check the schema errors. Maybe some idea?

Still remains to check the schema errors

Webflo, any comments on that?

Well, simple enough, the value schema is missing :)

See field.value.string for example in core.data_types.schema.yml.

Thanks for the help.
This should make the test pass and add all missing schema.

Thanks!

Looks like i missed some schema last time. Right now im getting some schema errors when I use a exported view. Really sorry I'm reopening this but its just a small fix i don't think we need to open a new issue.

Looks fine. This is related to #2691491: Add name field to the contact entity

+++ b/config/schema/name.schema.yml
@@ -385,12 +385,15 @@ field.formatter.settings.name_default:
+    markup:

Patch looks good, but the is no markup default setting in NameFormatter::defaultSettings. Can you fix the defaultSettings? Thanks!

Updated the NameFormatter::defaultSettings

RTBC.

Markup is a checkbox, i think boolean fits better in this case.