Add name field to the contact entity

I guess _crm_core_contact_contact_name_base() is related to that, as it defines name functionality and is currently unused.

Here is some initial code. There is an exception when i try to add a contact. In the name module name_element_pre_render when we checks the cardinality it tries to access the value as an array but we have a Drupal\name\Plugin\Field\FieldWidget\NameWidget.
Also tests are missing.

Think i we need to commit this dependencies so the test work.

Not sure how this lines affect activity UI tests.

fail: [Other] Line 33 of modules/crm_core/modules/crm_core_activity_ui/src/Tests/ActivityUiTest.php:
Unable to install modules: module 'crm_core_activity_ui' is missing its dependency module name.

Of course. This should be green.

Btw whats planned for the contact entity? The default household and organization don't make too much sense with the default name field settings(format). We need deferment field settings for these bundles. Are we going for field_ui_base_route?

just the name and entity dependencies.

There is an issue on #2629910: WSOD caused by 'description' as array that causes problems when using name field.

As discussed with @slashrsm updated the contact label to return first and last name. Also started with commenting out the tests but there are also some hardcoded urls and I would need to change a lot of code to make the test pass. So maybe it is ok for now to just use the name field for $household_node and $organization_node (left a comment there) until we split the contact into entities? It would be easier to later change them.

The test should fail since there are some not commited issues on name module. Like #2629910: WSOD caused by 'description' as array and #2700377: Call to undefined method on manage display

Same as #17. Reuploading to see if tests pass now.

Tried the patch and it breaks Collect as we are changing the base field type here which results in property definition mismatch with Name field in CRM Core Match.

+++ b/modules/crm_core_contact_ui/src/Tests/ContactUiTest.php
@@ -151,17 +167,23 @@ class ContactUiTest extends WebTestBase {
-    $this->assertLink('Johnson', 0, 'Updated individual contact title listed.');
+    $this->assertLink('Maynard Keenan', 0, 'Updated individual contact title listed.');

Changing to metal genre here. :)

Just added name to the modules list in the test.

@mbovan Thought to sneak in some names :) don't know about standards here.

Created a followup for CRM Core Match #2701979: Update Name field

This is just the dependency for crm_core matcher.

Same as #22.

Should fix some tests and update matcher for name field.

1. +++ b/modules/crm_core_match/src/Plugin/crm_core_match/field/Name.php
   @@ -31,55 +53,59 @@ class Name extends FieldHandlerBase {
      public function match(ContactInterface $contact, $property = 'value') {
   +    if (!($this->field instanceof FieldConfigInterface) && !($this->field instanceof BaseFieldDefinition)) {
   +      return [];
   +    }
   

   Not sure about this check...

2. +++ b/modules/crm_core_match/tests/src/Kernel/FieldMatcherTest.php
   @@ -1,11 +1,15 @@
   +/**
   + * @file
   + * Contains \Drupal\crm_core_match\Tests\FieldMatcherTest.
   + */
   

   Can be removed.

3. +++ b/modules/crm_core_match/src/Plugin/crm_core_match/field/Name.php
   @@ -31,55 +53,59 @@ class Name extends FieldHandlerBase {
   +    foreach ($this->getPropertyNames() as $property) {
   +      if ($contact->get($field_name)->{$property}) {
   +        $valid_parts[$property] = $contact->get($field_name)->{$property};
          }
   

   Talked with @Denchev about this.

   We are not sure if should have a CRM field per "real" entity field (1:1), or a property per entity field? (See the screenshot below)
   Do we want to allow a user to favorize properties of each field (e.g. "family" and "given" in Name field) or we should do the matching for a field (and check all the properties in the background)?
   

reroll

Changed tests and updated match so it only works with the defined property. #30.2 is removed, left #30.1 for now... i can for example remove it completely or check if this->field is defined not sure.

#30.3 created followup #2706203: Matcher form doesn't show properties

This change breaks Collect, so I think we should open a followup to update it with the changes here.

Still not sure about #30.1.

Overall, looks good.

The check is actually not rely needed, so i removed it completely, also updated the view. I have a few questions here:

1. I don't see any option in the view to make the name a link to the contact, and we don't have a view operation exposed. A followup on the name module?

2. We have to choose how the click sort works you have to choose one of given, title, family... I set it to family but not sure

3. The exposed filter works when we separate in different properties I don't see an options for both name and family to be in one exposed filter.

There will be test fails but i can fix them when we decide how the view should look and work.

created 2 followups #2709299: Combined views filter and #2709295: Link name field to the referenced entity

also there is some schema missing on name module i overlooked last time so when this patch [#2629910]is commited all test should be green.

Ok figured it out. This should fix the view.

Hard to review, but seems like good to go... We will need to update Collect with the changes introduced here.