Problem/Motivation

After #2575703: Remove default fall-through from PlaceholderTrait::placeholderFormat() !placeholders are not considered as valid and tests are failing.

Proposed resolution

Find the !placeholder usages and replace it with @placeholder.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 fix_placeholders-8.patch2.57 KBgiancarlosotelo
#3 fix_placeholders-3.patch2.57 KBgiancarlosotelo
#2 fix_placeholders-2.patch2.57 KBgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new fix_placeholders-2.patch2.57 KB

Patch should fix this.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new fix_placeholders-3.patch2.57 KB

sorry for url we should use ':'

See CR https://www.drupal.org/node/2575819

jribeiro’s picture

jribeiro commented
Status: Needs review » Fixed

Pushed to 8.x-1.x branch.

Thanks.

Status: Fixed » Needs work

The last submitted patch, 3: fix_placeholders-3.patch, failed testing.

jribeiro’s picture

jribeiro commented

@giancarlosotelo the test get fail. Can you please check this?

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new fix_placeholders-8.patch2.57 KB

After the commit the last patch doesn't apply anymore, so I am makinge a rebase as I said I think we should use ":" for the href attribute.

jribeiro’s picture

jribeiro commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.