Closed (fixed)
Project:
Page Manager
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Oct 2015 at 00:54 UTC
Updated:
24 Nov 2015 at 15:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkettThank goodness we locked this class down with unit tests. Refactoring this wouldn't have been possible otherwise.
Comment #3
tim.plunkettJustified the change to VariantRouteFilter::getRequestAttributes() with some test coverage.
Comment #4
dsnopekAssuming the core patch really does get committed (and so this is temporary), this looks good to me!
Comment #5
tim.plunkettThanks!
Comment #9
dsnopekTestbot's a little late to the party!
Comment #10
wim leers#2605250: ParamConverterManager::convert() should run once per request object landed. I think this can therefore be reverted?
Comment #11
tim.plunkettWe still need the changes to VariantRouteFilter, but yes the rest can go. Thanks!