Hi,

I maintain the Nagios module and we use it across a lot of sites. One of our clients installed this module and didn't configure it, which immediately triggered a "CRITICAL" alert for us! Not your fault, I appreciate, but it would be good if this module enabled its "quiet mode" by default, so status is WARNING instead of CRITICAL for this sort of scenario - unless someone states otherwise.

Patch to follow.

CommentFileSizeAuthor
#3 Quiet-by-default-2582109-3.patch545 bytesgreg.harvey
#2 Quiet-by-default-2582109-1.patch545 bytesgreg.harvey

Comments

greg.harvey created an issue. See original summary.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
StatusFileSize
new Quiet-by-default-2582109-1.patch545 bytes

Simple patch attached.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
StatusFileSize
new Quiet-by-default-2582109-3.patch545 bytes

Of course, it would help if I didn't get my diff back to front!

  • rupl committed bae2589 on 7.x-3.x 
    Issue #2582109 by greg.harvey, rupl: Quieter status messages for...
rupl’s picture

rupl
he/him
Primary language English
commented
Title: Consider quieter status messages for unconfigured module by default » Quieter status messages for unconfigured module by default
Category: Bug report » Task
Status: Active » Fixed

Until the latest release I'd have said no, because a custom build was required to include critical functionality that the module uses (implementations of hook_modernizr_load()). But hey, Modernizr v3 forced my hand on that one so I suppose this truly is less critical now.

The patch seems to be modifying a manual copy of the module file, so I made the same change and updated the comment to be clearer too.

rupl’s picture

rupl
he/him
Primary language English
commented

7.x-3.7 released: https://www.drupal.org/node/2583287

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.