Great module, I am using it on a complicated views filter page and using mefibs to expose the main filter and sort filter to separate blocks, it works great.

I am testing the site with page cache and found that mefibs.module is using session, it broke the page cache..

CommentFileSizeAuthor
#1 mefibs-cache_broken-2525890-1.patch1.49 KBeyilmaz

Comments

eyilmaz’s picture

eyilmaz
Primary language German
Location Berlin, Germany
commented
Status: Active » Needs review
StatusFileSize
new mefibs-cache_broken-2525890-1.patch1.49 KB

Check if filters is set. And if we should remember that before settings the session.

nsciacca’s picture

nsciacca
She/Her/Hers
Primary language English
commented

+1 for this patch. This fixes both the broken cache and values that were persisting across pages that Views was not configured to remember.

berliner’s picture

berliner commented
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Status: Needs review » Fixed

Thanks for the patch. Nice catch indeed!
Committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.