First off, for the DRUPAL-6--1 branch and HEAD, the po/ directory should be translations/.

Second off, as was mentioned in connection to the German translations, there were some errors. Here are the ones I'm seeing:

freso@nayru /s/h/l/h/d/s/a/m/mollom> php ../potx/potx-cli.php
Processing mollom.module...
Invalid marker content in mollom.module:1009
* t("$message: the Mollom services are operating correctly. We are now blocking spam.")

Invalid marker content in mollom.module:1012
* t("$message: your keys do not exist or are no longer valid. Please visit the user settings page on the Mollom website again: http://mollom.com/user.")

Invalid marker content in mollom.module:781
* watchdog('mollom',t('Ham: %message',array('%message'=>$data['post_body'])))

Invalid marker content in mollom.module:785
* watchdog('mollom',t('Spam: %message',array('%message'=>$data['post_body'])))

Invalid marker content in mollom.module:789
* watchdog('mollom',t('Unsure: %message',array('%message'=>$data['post_body'])))

Processing mollom.install...
Processing mollom.info...
Processing mollom.js...

Done.

CommentFileSizeAuthor
#5 mollom-i18n.d5.patch1.66 KBFreso
#2 mollom-i18n.d6.patch2.97 KBFreso
#1 mollom-i18n.d6.patch2.59 KBFreso

Comments

Freso’s picture

Freso commented
Status: Active » Needs review
StatusFileSize
new mollom-i18n.d6.patch2.59 KB

Here's a patch fixing the t() errors.

Three of the errors were from bad watchdog() calls. watchdog() shouldn't use t() in the 6.x+ API!

The other two had a variable in them. I circumvented this by enclosing the variable ($message = 'We contacted the Mollom servers to verify your keys';) in a t(), and then having the two strings calling it use @message with a mapping '@message' => $message. I'm not sure this is the best way to do it, so please let me know if you'd prefer to handle it some other way. (Like removing the $message altogether and copy it directly into the strings.) (Oh, and I'm also not sure what happens when a @variable is called twice, as @mollom-user is in one of the edited strings.)

Freso’s picture

Freso commented
StatusFileSize
new mollom-i18n.d6.patch2.97 KB

And this patch includes a correction for the typo found by the Swedish translator seals in #244736: Swedish translation.

dries’s picture

dries commented

Freso, you're obviously right. I did a sloppy job porting the module. Committed to DRUPAL-6. Thanks.

dries’s picture

dries commented
Status: Needs review » Fixed
Freso’s picture

Freso commented
Version: 6.x-1.x-dev » 5.x-1.1
Status: Fixed » Needs review
StatusFileSize
new mollom-i18n.d5.patch1.66 KB

The $message to @message should probably be back ported to the 5.x branch. So this I did.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to DRUPAL-5. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.