Was reading the code, wanted to understand the types of values that could be fed into

ConfigInspectorController::formatList() as $config_schema.

Traced it back to ConfigInspectorManager::convertConfigElementToList() found it was not quite what I expected....
[ It can also be a object ]

I wanted to document that... found myself fixing up a few other methods in the file.... might as well do it in public :)

Hope this helps.

CommentFileSizeAuthor
#2 interdiff-2.txt982 bytesmartin107
#2 formatList-2.patch2.37 KBmartin107
formatList-0.patch2.54 KBmartin107

Comments

Status: Needs review » Needs work

The last submitted patch, formatList-0.patch, failed testing.

martin107’s picture

martin107 commented
Status: Needs work » Needs review
StatusFileSize
new formatList-2.patch2.37 KB
new interdiff-2.txt982 bytes

Oh course that parameter should also be array|object

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks, while this is not perfect, what we had before was bad. We can always iterate on this. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.