We use required field a lot.
When the field is absent, the row of csv / node is not created what is what we want.

But it fails silently, there is no feedback whatsoever on how many rows, which rows where skipped or why.
This would be very useful if feeds is being used by regular users to upload stuff.

CommentFileSizeAuthor
#4 feeds_tamper-required-message-2492159-4.patch1.13 KBtwistor
#1 feeds_tamper-required-message-2492159-1.patch1.13 KBtwistor

Comments

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new feeds_tamper-required-message-2492159-1.patch1.13 KB

I haven't tested it, but something like this should work.

ikeigenwijs’s picture

ikeigenwijs commented
Assigned: Unassigned » ikeigenwijs

This looks splendid, i will test this thusday
thx twistor!

ikeigenwijs’s picture

ikeigenwijs commented
Status: Needs review » Needs work

Ok , later than planned.

The configuration field is available but it does not work.

There is no difference between enabled and disabled.
cleared cache after patching and enabling to be sure.

found this in watchdog:

Warning: Illegal offset type in drupal_set_message() (line 1789 of /var/www/d7_rcollectie/includes/bootstrap.inc).

Warning: Invalid argument supplied for foreach() in entityreference_feeds_feeds_processor_targets_alter() (line 120 of xxxx/sites/all/modules/entityreference_feeds/entityreference_feeds.module).

our mandatory field commes before a entityreference look up.

The basic workings are sill intact, node is not created, but no feedback.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_tamper-required-message-2492159-4.patch1.13 KB

Oops, yeah.e

ikeigenwijs’s picture

ikeigenwijs commented
Status: Needs review » Needs work

Ok, this patch works !!
Is it possible to add the line number of the skipped entry in the feedback message?
Otherwise RTBC, cant go much wrong here ,-)

twistor’s picture

twistor commented

It's not possible to add the line number, but we could be able to add the item number. For a CSV, it will be close. For others, it might be useful.

  • twistor committed 7845b7f on 7.x-1.x 
    Issue #2492159 by twistor, ikeigenwijs: Feedback set message when...
twistor’s picture

twistor commented
Status: Needs work » Fixed
ikeigenwijs’s picture

ikeigenwijs commented

We are indeed using csv imports an item number would be nice ;-)
thx for the commit

ikeigenwijs’s picture

ikeigenwijs commented
Assigned: ikeigenwijs » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.