Update and fix the tests!

@mglaman That's cool PSR-4 is supported, I didn't see that issue go in. Any chance you have a reference?

Also, is this what is needed to get automated testing to work and be turned on like you were mentioning on twitter?

See if we can't jar this to unpostponed.

@mglaman thanks I've committed everything except for this part which seems to have an issue when I ran the tests locally and I'm not sure what it's doing at first glance.

Fixed some exceptions with the json format and turned status back because that's how it exports as.

Ok that fixes the exceptions...

Discounts date 66 passes, 3 fails, 0 exceptions, and 4 debug messages
Discounts 186 passes, 7 fails, 0 exceptions, and 28 debug messages

Fail      Other      commerce_discount   68 CommerceDiscountDateTest->testDisco
    Start date is shown
Fail      Other      commerce_discount   69 CommerceDiscountDateTest->testDisco
    End date is shown
Fail      Other      commerce_discount   87 CommerceDiscountDateTest->testDisco
    Order discount is deducted when in time frame.
Fail      Other      commerce_discount  266 CommerceDiscountTest->testCommerceD
    Exported discount is identical to its origin.
Fail      Other      commerce_discount  282 CommerceDiscountTest->testCommerceD
Fail      Other      commerce_discount  307 CommerceDiscountTest->testCommerceD
    Percentage order discount is deducted correctly.
Fail      Other      commerce_discount  403 CommerceDiscountTest->testCommerceD
    2 discounts are listed as applied on the order.
Fail      Other      commerce_discount  404 CommerceDiscountTest->testCommerceD
    Two fixed order discounts are applied on the total price.
Fail      Other      commerce_discount  405 CommerceDiscountTest->testCommerceD
    An order with one product and two fixed order discounts has three line
    items.
Fail      Other      commerce_discount  407 CommerceDiscountTest->testCommerceD
    After updating the order it still has three line items.

Let's see if the dependencies are affected by the profile minimal (hope not)

I've got a machine that is reproducing the errors. Trying to track down why but the issue is primarily the address field module isn't enabling.

I'll have to dig deeper to sort that out.

Well similar but not the same error as testbot. I've commented out the failing tests that I couldn't fix off hand and will uncomment them as I resolve them.

These tests pass locally. Trying something a bit more drastic.

More drastic, committed hiding the submodule tests and added all depenencies to test_dependencies.

This test was the tricky one that was failing.

Some tests commented out, need to fix those. I think free_product has problem now.

Feel free help fix them:) or make them better in this issue! I'll commit green uncommented tests;)

Will it blend?

+++ b/modules/commerce_discount_usage/commerce_discount_usage.test
@@ -161,7 +161,7 @@ class CommerceDiscountUsageTest extends CommerceDiscountTestBase {
-    $order = $this->createDummyOrder($this->store_customer2->uid, array($this->product->product_id => 1), 'complete');
+    $order = $this->createDummyOrder($this->store_customer2->uid, array($this->product->product_id => 1), 'completed');

I've committed this change, thanks for spotting that @mglaman

And

+++ b/commerce_discount.test
@@ -470,20 +470,19 @@ class CommerceDiscountTest extends CommerceDiscountTestBase {
-    $discount = $this->createDiscount('product_discount', 'free_products', array($this->product->product_id));
+    $discount = $this->createDiscount('order_discount', 'free_products', array($this->product));

And this change was awesome that you found that. There is no free_products for product_discount and it gives one free and doesn't subtract from existing, that may have been legacy functionality.

Ok abused this issue enough. All the tests pass on Travis, locally on CLI and through the UI.

No more commented out tests! Thanks @mglaman for the help and encouragement.