Hi,
Could you please add new drush commands to enable/disable configured servers? Right now it is only possible to enable/disable index.
Thanks,
Yohan.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 2479453-10--drush_enable_servers.patch | 3.51 KB | rosinegrean |
| #6 | 2479453-6--drush_enable_servers--interdiff.txt | 3.41 KB | drunken monkey |
| #6 | 2479453-6--drush_enable_servers.patch | 3.87 KB | drunken monkey |
Comments
Comment #1
rosinegrean commentedHey,
@drunken monkey should confirm if this will be added or not in the module, but i can create a patch for this if he confirmes. And maybe add them to D8 version also.
Comment #2
drunken monkeySure, why not, if you think it's useful enough.
Personally, I'd not see that many use cases where you'd want to do this, but if you provide a patch, sure. (Also, big plus point for already mentioning D8, it should definitely be added there, too!)
Comment #3
rosinegrean commentedIf you can do it from back end, it might be useful to do it from Drush too.
I saw this comment
// @todo: Maybe add logic to print table of all servers.
in search_api_drush_get_server()
It might be a good idea to add a drush command to list the servers first, then to en/dis one of them.
I'll give it a try and let you know.
Thanks,
Comment #4
rosinegrean commentedI've added 3 new drush commands:
- sapi-sl for listing all the servers
- sapi-se for enabling a specified server
- sapi-sd for disabling a specified server
I'll wait for your input on this.
Thanks,
Comment #5
rosinegrean commentedHello,
I've cleaned a little the patch.
Also the patch for the D8 version is already ready, just waiting for your input.
Thanks,
Comment #6
drunken monkeyThanks a lot, good job!
There were a few minor code style issues, but other than that it looks good.
Please verify the attached patch still works for you, then I can commit it.
Comment #7
rosinegrean commentedThanks @drunken monkey
The patch still works.
Comment #9
drunken monkeyOK, great to hear!
Committed.
Thanks again!
You said you already have a patch for D8, too? That would of course be excellent, please post!
Comment #10
rosinegrean commentedYes, here it is.
I've followed the style from your patch for D7, hope it's all good.
Thanks,
Comment #12
drunken monkeyThanks a lot, looks good already!
Just two minor things:
The first lines of doc comments should start with a verb in third person.
In D8, there is no numeric ID anymore, there's just the "ID" (which is the previous "machine name").
Other than that it was great, so I just corrected those (and some phrasing) and then committed.
Thanks again!
Comment #14
yohanaraujo07@gmail.com commentedHi I wasn't aware of the issue crediting by the time I opened the ticket, can you please attribute the credit? Thanks!!
Comment #15
yohanaraujo07@gmail.com commented