Problem: hybridauth_update_7004() and hybridauth_update_7006() perform a user_load() for every single user account on the site. So the update function will take hours for a site with 100.000 users.

Proposed solution: query the database for entries where there actually is a password set in the blob.

CommentFileSizeAuthor
#1 hybridauth-empty-update-2476415-1.patch2.99 KBklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs work
StatusFileSize
new hybridauth-empty-update-2476415-1.patch2.99 KB

So I'm lazy and I don't have the password set feature enabled on my sites anyway, so I just wipe out those slow update functions.

Warning: do not use this unless you know what you are doing!

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Klaus,

Thank you for using the module and for the report.

So updates do actually work, but are running for a very long time, right?

Thanks
AndyB

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Security update functions do not work on large sites » Security update functions take hours on large sites

Yes.

  • duozersk committed 5e820db on 7.x-2.x 
    Fixed [#2476415] - optimized DB update queries
duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.