Problem/Motivation

The simpletest module (\core\modules\simpletest\simpletest.module) is including this component:

use Symfony\Component\Process\PhpExecutableFinder;

But this component went away when updgrading symfony to 2.6 in commit:

SHA-1: 3b945fe250e4af8ff6e121796ba28c9c22b16f04

* Issue #2366043 by dawehner: Upgrade to Symfony 2.6

I believe that it is impossible that this (broken simpletest) passed unaware for more than two weeks, so I am probably having something wrong here, just wanted to make sure....

Proposed resolution

Add the process component as explicit dependency. More details in #2389287-1: Missing PhpExecutableFinder

Remaining tasks

User interface changes

API changes

Original report by @david_garcia

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug, because tests don't run on windows.
Issue priority Critical, because we can't even in theory add CI support for windows without being able to run tests.
Disruption No disruption at all.
CommentFileSizeAuthor
#1 2389287-1.patch188.33 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2389287-1.patch188.33 KB

To be clear, this was not triggered, because this class is just used on windows platforms:

  if (substr(PHP_OS, 0, 3) == 'WIN') {
    $php_executable_finder = new PhpExecutableFinder();
    $php = $php_executable_finder->find();
    $phpunit_bin = escapeshellarg($php) . " -f " . escapeshellarg(\Drupal::root() . "/core/vendor/phpunit/phpunit/composer/bin/phpunit") . " --";
  }

On the other hand, this was never defined in our composer.json file.
This code though was part of our vendor directoy, because HttpKernel/composer.json has a require-dev dependency to the process component.

david_garcia’s picture

david_garcia commented
Related issues: +#2366043: Upgrade to Symfony 2.6.0-beta1

Tests are working now on windows platform. Thanks.

david_garcia’s picture

david_garcia commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed ee28700 on 8.0.x 
    Issue #2389287 by dawehner: Missing PhpExecutableFinder

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hass’s picture

hass commented

I still cannot run any UnitTest on Windows!?