Hello maciej,

The language conditions exposed in search_api_et_entity_update are too restrictives and it should be removed from that function. Please find a patch to solve this issue.

Best,
jo

CommentFileSizeAuthor
#4 search_api_et-restrictive_language-2377957-3.patch753 bytesmaciej.zgadzaj
useless-language-conditions.patch1.86 KBjkuma

Comments

maciej.zgadzaj’s picture

maciej.zgadzaj commented
Status: Needs review » Fixed

Thanks mate! Committed and pushed to d.o.

  • maciej.zgadzaj committed 874030d on 7.x-2.x 
    Revert "Issue #2377957 by goldorak: Useless language conditions on...
maciej.zgadzaj’s picture

maciej.zgadzaj commented
Status: Fixed » Needs review
StatusFileSize
new search_api_et-restrictive_language-2377957-3.patch753 bytes

Actually, that was a hasty commit, and is not really right - thus got reverted.

Both !empty() checks should be left there, the only one to be removed is last language comparison - otherwise it will raise Notice: Undefined property: Entity::$language for each entity without language property defined.

Proposed patch attached. I'm open to discussion.

Status: Needs review » Needs work

The last submitted patch, 4: search_api_et-restrictive_language-2377957-3.patch, failed testing.

jkuma’s picture

jkuma commented
Status: Needs work » Reviewed & tested by the community

Fine for me, thanks for the review!

  • maciej.zgadzaj committed a56f527 on 7.x-2.x 
    Issue #2377957 by goldorak: Useless language conditions on entity update...
maciej.zgadzaj’s picture

maciej.zgadzaj commented
Status: Reviewed & tested by the community » Fixed

Take #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, useless-language-conditions.patch, failed testing.