Problem/Motivation

There was no twitter feed name in the api query.

Proposed resolution

I propose having a new column: "name", and fill the "name" from the API in the "tweet_feed_process_tweets" function.

CommentFileSizeAuthor
#5 add_name_field-2366067-3.patch2.56 KBbogdan.racz
#2 add_name_field-2366067-2.patch2.56 KBbogdan.racz
#1 add_name_field-2366067-1.patch1.98 KBbogdan.racz

Comments

bogdan.racz’s picture

bogdan.racz commented
StatusFileSize
new add_name_field-2366067-1.patch1.98 KB

Added patch for this.

bogdan.racz’s picture

bogdan.racz commented
StatusFileSize
new add_name_field-2366067-2.patch2.56 KB

Forgot to add views field handler.

elusivemind’s picture

elusivemind commented

Name in your schema will need to have a default value if it cannot be null or we risk issues upgrading previous modules. Either that or this field should be allowed to be null.

Also - I issued an update to dev last night. Would it be possible to patch this against the dev branch and re-submit? I would greatly appreciate it.

elusivemind’s picture

elusivemind commented
Status: Needs review » Needs work
bogdan.racz’s picture

bogdan.racz commented
StatusFileSize
new add_name_field-2366067-3.patch2.56 KB

Re-rolled the patch for the latest dev on 7.x-1.x
Thanks for all the work.

bogdan.racz’s picture

bogdan.racz commented
Status: Needs work » Needs review

Needs review.

bogdan.racz’s picture

bogdan.racz commented

Duplicate.

elusivemind’s picture

elusivemind commented

Going to be reviewing this in the next day or two. I may have one addition on top of it.

elusivemind’s picture

elusivemind commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.