Problem: drupal_goto() stops the request execution and other form submit handlers don't get a chance to alter the redirect target. drupal_goto() must not be used in form submission callbacks.

Solution: use $form_state['redirect'] instead.

CommentFileSizeAuthor
#1 pw-hustle-redirect-2362439-1.patch890 bytesklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
StatusFileSize
new pw-hustle-redirect-2362439-1.patch890 bytes

Patch attached.

SolomonGifford’s picture

SolomonGifford commented

I've been trying very hard not to deviate from core behavior in this module to avoid feature creep and unexplained behavior. See the user module for the fact that drupal_goto is used. However, your patch does fit in with the spirit of what this module is doing in the sense that we are allowing the user to not have to go to the edit page after login. It also may partially solve #2091607: Incompatible with login_history module.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Patch looks good to me. RTBC?

SolomonGifford’s picture

SolomonGifford commented
Status: Needs review » Closed (fixed)

Applied. Thanks.