Hy,

After I updated the module, I got an error:

Undefined index: webform in webform_tokens_tokens

I compared the changes between two versions of the module and I think I found a bug. (version 1.2 and 1.7)

  if ($type === 'webform' && isset($data['webform']) && is_object($data['webform'])) {
    $submission = $data['webform'];
    [...]

VS

  // Support [webform:] tokens if Webform Rules is not enabled.
  if ($type == 'webform' && module_exists('webform_rules') === FALSE) {
    $type = 'webform-tokens';
    $data['webform-tokens'] = $data['webform'];
  }

  if ($type === 'webform-tokens' && isset($data['webform-submission']) && is_object($data['webform-submission'])) {
    $submission = $data['webform-submission'];
    [...]

Why $data['webform-tokens'] = $data['webform'] ?

$data['webform-tokens'] is not used after.

I think the variable should be $data['webform-submission'] = $data['webform'].

The modified code :

  if ($type == 'webform' && isset($data['webform']) && module_exists('webform_rules') === FALSE) {
    $type = 'webform-tokens';
    $data['webform-submission'] = $data['webform'];
  }

  if ($type === 'webform-tokens' && isset($data['webform-submission']) && is_object($data['webform-submission'])) {
    $submission = $data['webform-submission'];

Thx.

Comments

liam morland’s picture

Thanks for the report. Please provide your suggested changes as a patch.

  • Liam Morland committed 1851e15 on 7.x-1.x
    Issue #2359971: Fix Undefined index: webform in webform_tokens_tokens().
    
liam morland’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.