There are quite a few non-Drupal theme dependencies that aren't currently documented. Attached is a patch of a proposed addition to the "Configuration" section of the README.md.

CommentFileSizeAuthor
#3 interdiff.txt1.43 KBdcmouyard
#3 gesso-dependency-documentation-2357503-3.patch1.48 KBdcmouyard
#1 interdiff.txt2.85 KBdcmouyard
#1 gesso-dependency-documentation-2357503-1.patch1.55 KBdcmouyard
add-dependencies-documentation.patch1.64 KBldavisrobeson

Comments

dcmouyard’s picture

dcmouyard commented
Status: Active » Needs review
StatusFileSize
new gesso-dependency-documentation-2357503-1.patch1.55 KB
new interdiff.txt2.85 KB

This patch updates the markdown to match coding standards. I also added some text about looking at the README.md in the sass directory for more information about installing Bundler and compiling Sass.

ldavisrobeson’s picture

ldavisrobeson commented

I just realized I forgot to take out the mention of the Gruntfile.js, which probably shouldn't be included since it's not part of the theme.

dcmouyard’s picture

dcmouyard commented
StatusFileSize
new gesso-dependency-documentation-2357503-3.patch1.48 KB
new interdiff.txt1.43 KB

I removed the comment about Gruntfile.js and moved the "Non-Drupal configuration files" section above the "Sass dependencies" section in this patch.

ldavisrobeson’s picture

ldavisrobeson commented
Status: Needs review » Reviewed & tested by the community

Patch worked, looks good to me.

dcmouyard’s picture

dcmouyard commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.