Hey,

i noticed this module breaks all javascripts on newest chrome. the images don't work and you get error on console about this module. please fix it

Comments

attiks’s picture

attiks commented

The easiest is to switch to the picture module

attiks’s picture

attiks commented

A new dev version is pushed using the new polyfill, can you test?

jens_dot_jens’s picture

jens_dot_jens commented

I don't see the pics now at all, on any browser. But now there is no JS errors anymore at least. Inside picture tag should there be <img> tag also? Because looking my site with devtools, it has <picture> and <source> tags inside with correct URLs but <img> tag is missing.

I guess the picture module has totally different settings etc? So it would set up and template/CSS changes on my site? That's ok, but this site is production site so it would be nice if this module would be fixed so with time I could move to this new module.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Version: 7.x-2.0-beta3 » 7.x-2.x-dev
Status: Active » Fixed

Fixed in the latest dev version

jens_dot_jens’s picture

jens_dot_jens commented

Erhm, is it fixed, really?

  • Jelle_S committed 5176491 on 7.x-2.x 
    Issue #2352795 by jens_dot_jens: Fixed Breaks site on Chrome Beta / 38.
jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented

Ugh, sorry, didn't push. Should be fixed now ;-)

jens_dot_jens’s picture

jens_dot_jens commented

It loads the picture now but doesn't change. So I feel picturefill isn't working now? My markup looks like this, when looking devtools:

<picture class="resp-img-picture">
  <source media="(min-width: 0px)" srcset="http://www.mydomain/sites/default/files/styles/mobile/public/photo.jpg 1x">
  <source media="(min-width: 720px)" srcset="http://www.mydomain/sites/default/files/styles/desktop/public/photo.jpg 1x">
  <img srcset="http://www.mydomain/sites/default/files/styles/mobile/public/photo.jpg" alt="" title="">
</picture>

So it just loads the mobile size image on page load but doesn't change to desktop version when browser width is > 720px. Same thing on all browsers.

attiks’s picture

attiks commented

Picture (and the new polyfill) will use the first matching source, so you have to re-order your breakpoints

jens_dot_jens’s picture

jens_dot_jens commented

You mean from Breakpoints settings I just change the order? For example in my case I move desktop breakpoint first and then mobile (now mobile first and then desktop)? It doesn't seem to have any difference. It loads the mobile size and it' doesn't change the pic when resizing the browser.

attiks’s picture

attiks commented

Yes, but check the HTML output or clear all caches

jens_dot_jens’s picture

jens_dot_jens commented

Clearing caches didn't help and HTML output looks same as previously. It prints the mobile as default.

4kant’s picture

4kant commented

Same here. The default can never be changed. Is always keeps beeing "mobile".

attiks’s picture

attiks commented

#12, #13 What browser are you using to test

jens_dot_jens’s picture

jens_dot_jens commented

Newest Firefox, newest Chrome, newest Safari on Mac. It doesn't change in any browser.

4kant’s picture

4kant commented

Same here but Windows ;-(

4kant’s picture

4kant commented

I just realized that it seems to work when I

  1. reorder breakpoints
  2. resave every mapping in res_img

The second step is what I haven`t done before.

@jens_dot_jens: can you confirm that?

attiks’s picture

attiks commented

4kant, you're right, you have to save them again since the order is saved as well

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.