Drupal 6 has a new $signature that gets added to comments. In advforum, I make it get added to nodes as well. Since the D5 and D6 themes are the same, it tries to print the $signature in D5, which is just empty. What would be nice is if I could assign the signature_forum signature to that variable and make use of it. So what I would like is an option to not automatically add the signature to content and, instead, call it via a function. Something like signature_forum_get_signature($uid). Another advantage of this is being able to place the signature whereever you want in the .tpl.

If you're interested but don't have time to do it, I can write a patch. But I've got some other stuff I need to do first, so I figured I'd at least get the FR out there.

Michelle

Comments

liam mcdermott’s picture

liam mcdermott commented

This is an interesting one. The problem is going to be the logic, so the function will look more like: signature_forum_get_signature($uid, $a2) where $a2 is either a node or comment object. How does that sound?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Sure, that should be fine. Both of those are available in the spot I want to use them. Curious why, though? Isn't the signature per user, not per node/comment?

Michelle

liam mcdermott’s picture

liam mcdermott commented

Curious why, though? Isn't the signature per user, not per node/comment?

Signatures are only shown for certain node types, also there's a feature request to only show signatures once per conversation. I'm working on this now, I've done what you need, but #195703: Show Signatures once is--as I expected--really difficult to implement. :)

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Ah, nice. I think this module will really handle all the signature needs for forums. D6 gets better than D5 in core, but this adds some extra goodies that are really needed for forums.

Thanks,

Michelle

liam mcdermott’s picture

liam mcdermott commented
Status: Active » Fixed

I've added this, and a bunch of other functionality, grab the latest Beta and test it out. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.