Problem/Motivation

The Workbench Scheduler module keeps schedule data in its own table structure. We should create some Drupal Simpletests to check the integrity of that data.

API changes

I created two tests for Workbench Scheduler.

  • A test for new Schedules
  • A test for when a schedule is assigned to a node.

If anyone has any other ideas for more tests I'd like to hear them :)

CommentFileSizeAuthor
#8 workbench_scheduler.simpletests-2343015.8.patch13.11 KBpartdigital
#6 workbench_scheduler.simpletests-2343015.6.patch11.9 KBpartdigital
#3 workbench_scheduler.simpletests-2343015.3.patch11.98 KBpartdigital
#1 workbench_scheduler.simpletests-2343015.patch6.88 KBpartdigital

Comments

partdigital’s picture

partdigital commented
Issue summary: View changes
StatusFileSize
new workbench_scheduler.simpletests-2343015.patch6.88 KB
partdigital’s picture

partdigital commented
Status: Active » Needs review
partdigital’s picture

partdigital commented
StatusFileSize
new workbench_scheduler.simpletests-2343015.3.patch11.98 KB

Here is an updated patch that includes a wider array of tests. It coincides with work done on the following issues:
https://www.drupal.org/node/2348677
https://www.drupal.org/node/2352379

Apply those patches before applying this.

partdigital’s picture

partdigital commented
Parent issue: » #2348677: Saving a new revision of a node creates a new schedule entry for that revision
Related issues: +#2352379: Node schedule manager page improvements
mikemiles86’s picture

mikemiles86
he/him
commented
Status: Needs review » Needs work

@partdigital,

I was unable to apply this patch to the 7.x-1.x branch. Can you re-roll it?

partdigital’s picture

partdigital commented
StatusFileSize
new workbench_scheduler.simpletests-2343015.6.patch11.9 KB

Here is the rerolled patch off the 7.x-1.x branch

partdigital’s picture

partdigital commented
Status: Needs work » Needs review
partdigital’s picture

partdigital commented
StatusFileSize
new workbench_scheduler.simpletests-2343015.8.patch13.11 KB

I found a bug with the previous patch, I've rerolled it off of 7.x-1.x. This will be merged into the dev branch.

  • partdigital authored 72c2367 on 7.x-1.x 
    Issue #2343015 by partdigital: Workbench Scheduler Tests
partdigital’s picture

partdigital commented
Status: Needs review » Closed (fixed)