Summary

Some browsers, such as Firefox and Chrome, now block all non-https content from loading on https pages. The Flickr embeds are hard-coded to 'http://' in the module.

Steps to recreate

  • On an SSL-enabled site, view a page with a Flickr embed on http:// -- embed works fine
  • View the page with https:// -- the embed disappears

Proposed resolution

Remove all hard-coded http:// references from the module in favour of https (since all of Flickr is https we don't need protocol independent URLs).

(Also remove unused MEDIA_FLICKR_MAIN_URL const from module file)

CommentFileSizeAuthor
#6 media_flickr-ebmed_on_https_sites_broken-2333409-6.patch6.59 KBsteinmb
#2 media_flickr_7.x_1.x-fix-https-2333409-2.patch3.77 KBjkingsnorth
#1 media_fickr-https-fix-2333409-1.patch2.8 KBjkingsnorth

Comments

jkingsnorth’s picture

jkingsnorth commented
Status: Active » Needs review
StatusFileSize
new media_fickr-https-fix-2333409-1.patch2.8 KB

Patch for 7.x-2.x attached

jkingsnorth’s picture

jkingsnorth commented
StatusFileSize
new media_flickr_7.x_1.x-fix-https-2333409-2.patch3.77 KB

Backported patch for 7.x-1.x attached

jkingsnorth’s picture

jkingsnorth commented
Issue summary: View changes
steinmb’s picture

steinmb commented
Status: Needs review » Fixed

Thank you John for helping out. Commited to both 7.x branches:
7.x-2.x commit 575bc31a13e09b6b23f8df5208c307d07e3b20a2
7.x-1.x commit ec715082f7d55f0c5beadb3b4fe5a6b1f48a1deb

steinmb’s picture

steinmb commented
Version: 7.x-2.x-dev » 6.x-1.x-dev
Assigned: Unassigned » steinmb
Status: Fixed » Active

On second thought. Let see if we can get patch 6.x -branch as well.

steinmb’s picture

steinmb commented
Status: Active » Needs review
StatusFileSize
new media_flickr-ebmed_on_https_sites_broken-2333409-6.patch6.59 KB

Note: Untested patch.

  • steinmb committed a2d1804 on 6.x-1.x 
    Issue #2333409 by steinmb: Avoid browsers blocking content in mixed-mode...
steinmb’s picture

steinmb commented
Status: Needs review » Fixed
jkingsnorth’s picture

jkingsnorth commented

Doh, looks like I didn't format the patch properly so the author attribution didn't kick in. Never mind, happy to help =]

steinmb’s picture

steinmb commented

You got mention in:
http://cgit.drupalcode.org/media_flickr/commit/?id=ec71508
http://cgit.drupalcode.org/media_flickr/commit/?id=575bc31

Also rolled a new version of this module. The official version was getting very long in the tooth. Thanks for helping out. I just stepped in as a co maintainer and is still trying to get a overview of what works and what does not in this module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.