Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Summary
Some browsers, such as Firefox and Chrome, now block all non-https content from loading on https pages. The Flickr embeds are hard-coded to 'http://' in the module.
Steps to recreate
- On an SSL-enabled site, view a page with a Flickr embed on http:// -- embed works fine
- View the page with https:// -- the embed disappears
Proposed resolution
Remove all hard-coded http:// references from the module in favour of https (since all of Flickr is https we don't need protocol independent URLs).
(Also remove unused MEDIA_FLICKR_MAIN_URL const from module file)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | media_flickr-ebmed_on_https_sites_broken-2333409-6.patch | 6.59 KB | steinmb |
| #2 | media_flickr_7.x_1.x-fix-https-2333409-2.patch | 3.77 KB | JKingsnorth |
| #1 | media_fickr-https-fix-2333409-1.patch | 2.8 KB | JKingsnorth |
Comments
Comment #1
JKingsnorth CreditAttribution: JKingsnorth commentedPatch for 7.x-2.x attached
Comment #2
JKingsnorth CreditAttribution: JKingsnorth commentedBackported patch for 7.x-1.x attached
Comment #3
JKingsnorth CreditAttribution: JKingsnorth commentedComment #4
steinmb CreditAttribution: steinmb commentedThank you John for helping out. Commited to both 7.x branches:
7.x-2.x commit 575bc31a13e09b6b23f8df5208c307d07e3b20a2
7.x-1.x commit ec715082f7d55f0c5beadb3b4fe5a6b1f48a1deb
Comment #5
steinmb CreditAttribution: steinmb commentedOn second thought. Let see if we can get patch 6.x -branch as well.
Comment #6
steinmb CreditAttribution: steinmb commentedNote: Untested patch.
Comment #8
steinmb CreditAttribution: steinmb commentedComment #9
JKingsnorth CreditAttribution: JKingsnorth commentedDoh, looks like I didn't format the patch properly so the author attribution didn't kick in. Never mind, happy to help =]
Comment #10
steinmb CreditAttribution: steinmb commentedYou got mention in:
http://cgit.drupalcode.org/media_flickr/commit/?id=ec71508
http://cgit.drupalcode.org/media_flickr/commit/?id=575bc31
Also rolled a new version of this module. The official version was getting very long in the tooth. Thanks for helping out. I just stepped in as a co maintainer and is still trying to get a overview of what works and what does not in this module.