Seven theme's uppercasing of details summaries fails on the Simpletest results form

Thanks for raising this issue. I didn't notice this.

1. +++ b/core/themes/seven/css/style.css
   @@ -1581,3 +1581,13 @@ details.fieldset-no-legend {
   +.simpletest-results-form summary {
   

   We should write this class in a way that is reusable, something like .summary--camel-case? Then other modules can use this if they also display camel cased strings in summaries.

2. +++ b/core/themes/seven/css/style.css
   @@ -1581,3 +1581,13 @@ details.fieldset-no-legend {
   +  text-transform: none;
   

   Maybe this would look better using small caps? It looks a little weird now https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant#Examples

Assigning this to me as part of the Drupal Code Sprint.

I've added the summary.summary-camel-case class that can be used in other modules.

Result:

Thanks!

+++ b/core/themes/seven/css/style.css
@@ -693,6 +693,11 @@ details summary {
+.simpletest-results-form summary,
+summary.summary--camel-case {

Can we remove the old class and insert that class in to the summary? Then we wouldn't need to have both.

Also, we can remove the element from the selector and just have .summary--camel-case

Novice task

Previous patch now (with the new file structure) don't apply.

this new one applies and solves the problem.

+++ b/core/themes/seven/css/base/elements.css
@@ -27,6 +27,9 @@ summary,
+#edit-drupalsystemtestsactionactionunittest summary{
+  text-transform: none;
+}

hmm I'd still rather not use IDs, classes are better, a reusable class is great.

Ups,

I forgot the status

Taking this up, fixing the whitespace and reviewing.

Added a whitespace to keep the CSS format correct, and reviewed the patch by running tests.

Tested, works in lowercase.

hm, so patch #5 had styling like this:

+++ b/core/themes/seven/css/style.css
@@ -693,6 +693,11 @@ details summary {
+.simpletest-results-form summary,
+summary.summary--camel-case {
+  text-transform: none;
+  font-variant: small-caps;
+}

But now patch #15 has styling like this?

+++ b/core/themes/seven/css/base/elements.css
@@ -27,6 +27,9 @@ summary,
+.simpletest-results-form summary {
+  text-transform: none;
+}

Can we also use the summary--camel-case class? I'm happy to help to show how we will add the class to the right elements

Here's a new patch with both classnames

Yes, my bad. The latest one seems to be correct.

Setting as RTBC.

Thanks, we are still using the previous styling, I think the styling with the small caps is good (see #5).

I would love it if we could do two tother things:
1. Remove the summary from summary.summary--camel-case as it is not needed
2. Remove .simpletest-results-form summary and then apply the .summary--camel-case to the simple test summary elements. This will involve some php but we can do that after the other stuff

So this is a patch with the small-caps font-variant and only the .summary--camel-case class, but the .summary--camel-case class hasn't yet been applied to the simple test summary elements.

Working on adding the class

Ok I added this class to only simpletest summary elements. I'm not sure if I'm checking the right variable though.

Go tests!

I works fine for me

But the second part that is all has no caps looks weird with the font-variant: small-caps; - why are we doing this? Also it is not camel case - our class names are Drupal\user\Tests\UserPasswordResetTest - not that \user\ is not camel case.

Based on @alexpott comment in #32 and making the suggested change in the original report, we can apply @jOksanen suggestion in #15. The patch no longer applies. This needs a reroll.

Result:

After speaking with dinarcon during Core Mentoring hours, I'll look at getting this reroll done tonight.

Rerolled patch from #15.
Conflicted in merge, where a comment had been added since. I changed the order so the comment related to the CSS below..

/**
 * Reusable heading classes are included to help modules change the styling of
 * headings on a page without affecting accessibility.
 */

I tested this and seems ok to me + Screenshot attached.
Anyone else can say if it's fine?

Result:

Sounds good, not a perfect solution but at least we fix this bug.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed f8bf34c and pushed to 8.0.x. Thanks!