function _profiler_builder_export_variables() cannot handle deeply nested variables

CommentFileSizeAuthor
#3 deeply_nested_variables-2326889-3.patch3.96 KBmarbard
#1 deeply_nested_variables-2326889-1.patch3.91 KBmarbard

Comments

marbard’s picture

marbard commented
StatusFileSize
new deeply_nested_variables-2326889-1.patch3.91 KB

Implemented a patch which goes through variables recursively

btopro’s picture

btopro commented
Status: Active » Needs work

FINALLY someone tackling this (thank you). :) My previous solution was from like 3 years ago and was horrible. Can we get some additional testing on this?

One thing to note in the patch; can you change the function name from _flatten_array to _profiler_builder _flatten_array. I'm a stickler for namespacing on all helper functions.

marbard’s picture

marbard commented
StatusFileSize
new deeply_nested_variables-2326889-3.patch3.96 KB

I've renamed the function as you've requested.
We've used this patch in my workplace, seems to work fine. Though additional testing wouldn't hurt I suppose :-)

btopro’s picture

btopro commented
Status: Needs work » Fixed

excellent! tested on simplytest.me and it looked good Thanks for another great patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.