I am using both this module and Field Label Plurals but it seems that this module is overwriting the effect of the module (having different text in the label for when there is only one value), instead of complimenting it (only overwriting the edit field name).

Essentially it seems like the modules are being run in the wrong order - FDL should be run first (to change the label on display), then FLP (to change it again if the value is singular),

Is there any this can be achieved? I apologise if I should be posting this as an issue with FLP instead of FDL - I haven't checked the code.

Comments

natts’s picture

Niklas Fiekas’s picture

StatusFileSize
new645 bytes

Hi,

this patch should be a first step in the right direction. As far as I can tell there is no need to forcibly register field_display_label_preprocess_field as the last preprocess function to be executed. By it's name alone it already implements hook_preprocess_HOOK() for theme_field().

After that it works on my test site, but it's probably pure luck that the order is now correct. We should have a look at that once this is sorted out.

Best regards
Niklas

plazik’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community
StatusFileSize
new828 bytes

@Niklas Fiekas, thank you for the patch. I've just added a proper comment for preprocess function.

  • Plazik committed e285933 on 7.x-1.x authored by Niklas Fiekas
    Issue #2326749 by Niklas Fiekas, Plazik: Make compatible with Field...
plazik’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.