There is warning on Update billing information page (regular logged on user without any subscriptions)
Notice: Undefined index: #coupon_code in recurlyjs_element_expand() (line 291 of /var/www/public_web_root/sites/all/modules/recurly/modules/recurlyjs/recurlyjs.module).

CommentFileSizeAuthor
#1 2325869.1-undefined-index.patch885 bytesdeviantintegral
patch.txt372 bytespalyan

Comments

deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 2325869.1-undefined-index.patch885 bytes

Ran into this as well. The patch code is fine, but I had to reroll it as it wasn't against the Recurly module. @palyan, https://www.drupal.org/node/707484 has directions on how to create a patch so others can apply it. Also, if you name it with something more descriptive (node id, comment number, description) it means others can commit the patch to their own sites and easily know where it's from.

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented

This looks like it's a duplicate of #2447793: Fixing PHP notice, and they both have a similar solution.

aburke626’s picture

aburke626
she/her
Primary language English
Location Lehighton, PA, US
commented
Assigned: Unassigned » aburke626
Status: Needs review » Reviewed & tested by the community

This looks good, I closed #2325869: Undefined index #coupon_code in recurlyjs_element_expand() as a duplicate as the error checking here is a little more robust and can't hurt. I'll get this into the next release, as we now have a handful of small updates to push out.

aburke626’s picture

aburke626
she/her
Primary language English
Location Lehighton, PA, US
commented
Status: Reviewed & tested by the community » Closed (fixed)