The project comes bundled with a file named icons.png (http://cgit.drupalcode.org/sticky_sharrre_bar/tree/icons/icons.png). This file is a derivative work created from a pack downloaded from http://sensationalfix.com/flat-social-icons-eps/.

The in question pack includes the copyright infosheet shown below:

copyright infosheet

Hence, icons.png is third party content. Third party content is not generally allowed on Drupal.org and should be deleted.

This particular asset is made available by its author for reuse under the Creative Commons Attribution-ShareAlike (CC BY-SA) license. While it is perfectly legal under this license to create a derivative distribute it under CC BY-SA (provided the license is honored, see below), all assets hosted on Drupal.org must be licensed under the GPL V2+ license.

This policy is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy.

It should be noted that the Git license policy is under review, and that third party content under under CC BY-SA may be allowed under a revised policy.

This notice is posted to bring this project (along with others in the same situation) under review. Please postpone acting upon the above until the policy issue regarding licensing is resolved.

Attribution required

Using material under a Creative Commons Attribution-ShareAlike license requires the licensee to comply with the license terms. This has not been done here. To repair this breach of license, please make sure that the following is added to the project's README.txt.

The file icons.png is derived from work that is Copyright Jorge Calvo  (http://sensationalfix.com/).
Source:  http://sensationalfix.com/flat-social-icons-eps/.
Used here under the Creative Commons Attribution-ShareAlike (CC BY-SA) license.

The missing attribution should be added to the project README.txt as soon as possible.

Comments

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Assigned: Unassigned » ruslan piskarov
Related issues: +#2268995: [D7] Sticky Sharrre Bar

Hi @gisle,
I remember this was discussed here https://www.drupal.org/node/2268995#comment-8947111.
I do not understand about the different types of licenses, so I re-read your advice and fix it in the next few days.
Thank you for your care.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes

It would be nice if you could add the missing attribution text to the project's README.txt. I've updated the issue summary with exact instructions about what you need to do.

There is no need to replace or remove the icons.png yet. Yours is not the only project that uses third party content, and we're reviewing the policy. One possible outcome of the review is that this shall be allowed.

I've set status to "Postponed" for now. I'll get back when the policy review is completed (which will probably take some time).

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes

Fixed typo.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes

Split policy and attribution issues.

  • Ruslan Piskarev committed 202ffda on 7.x-1.x 
    Issue #2314293 by Ruslan Piskarev: Drupal Git Repository Usage policy...
ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Status: Postponed » Active

Hi @gisle,
I fixed it in the brunch 7.x-1.x.
Now I want to push these changes to the tag 7.x-1.0 and what I'm doing wrong :-(

git clone git://git.drupal.org/project/sticky_sharrre_bar.git sticky_sharrre_bar; cd ./sticky_sharrre_bar/
git checkout 7.x-1.0
git cherry-pick 9476838f727df77373308c2abb38615a1a36b251
git cherry-pick 202ffda99c894967b6035a605fb6e2bfe51bcd61
git push

or

git clone git://git.drupal.org/project/sticky_sharrre_bar.git sticky_sharrre_bar_for_tag; cd ./sticky_sharrre_bar_for_tag/
git branch a 7.x-1.0
git checkout a
git cherry-pick 9476838f727df77373308c2abb38615a1a36b251
git cherry-pick 202ffda99c894967b6035a605fb6e2bfe51bcd61
git tag -d 7.x-1.0
git tag 7.x-1.0
git push origin :7.x-1.0
git push origin 7.x-1.0

I got the fatal error.

Maybe I should create a new 7.x-1.1 tag?

Sorry for such a question. This is my first module and I have a little experience work with git + drupal repo.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented

You must create a new tagged release (i.e. 7.x-1.1). You should never delete an existing tag or push to a release with the same number as one that already exists. There is no need to clone anything or to "cherry-pick" to do what you want. Assuming the HEAD of your local repo have the right version of README.txt (and it looks correct, I briefly inspected the HEAD of 7.x-1.x you pushed about two hours ago), you just create a new tag and push it.

First, make sure you're on branch 7.x-1.x. I.e. git status should report:

# On branch 7.x-1.x
Nothing to commit, working directory clean.

If that is not what the status-command tells you, stop and ask here before proceeding.

When the status is clean, do the following:

git tag 7.x-1.1
git push origin tag 7.x-1.1

Now the new tagged release should exist in your remote repo.
You can now click on "Add new release" at the bottom of your project page to get the 7.x-1.1 release packaged and a download link to it placed on the the project page (packaging takes 5-10 minutes).

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Status: Active » Needs review

@gisle,
The new 7.x-1.1 tag and release was created.
Thank you very much.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Postponed

Setting status back to "Postponed" to await outcome of site-wide policy review process.

  • Ruslan Piskarev committed 202ffda on 8.x-1.x 
    Issue #2314293 by Ruslan Piskarev: Drupal Git Repository Usage policy...
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Postponed » Fixed

The Drupal Git Repository Usage policy has been changed.

The very hard restrictions on including 3rd party assets has been lifted, and been replaced with the much more reasonable:

Any third party assets you include must have their provenance, license and source documented in a file included in the project.

The README contains the required documentation. No action is required by the maintainer.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.