Hi!

I think it would be great if the "more tags" links could be hide with settings, instead of any other dirty ways (ex.: display: none).

CommentFileSizeAuthor
#10 tagclouds-optionally-hide-more-tags-links-2313527-10.patch2.42 KBmxr576
#9 tagclouds-optionally-hide-more-tags-links-2313527-9.patch2.41 KBmxr576
#8 tagclouds-optionally-hide-more-tags-links-2313527-8.patch2.15 KBjoseph.olstad
#6 tagclouds-optionally-hide-more-tags-links-2313527-6.patch2.15 KBk4v
#1 tagclouds-optionally-hide-more-tags-links-2313527-1.patch2.14 KBmxr576

Comments

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new tagclouds-optionally-hide-more-tags-links-2313527-1.patch2.14 KB

... and here is my patch for the required functionality.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
k4v’s picture

k4v commented

Works for me, thank you =)

k4v’s picture

k4v commented
Status: Needs review » Reviewed & tested by the community
k4v’s picture

k4v commented
Status: Reviewed & tested by the community » Needs work

Theres a problem: The settings array $form['tags'] is overwritten by the patch.

k4v’s picture

k4v commented
StatusFileSize
new tagclouds-optionally-hide-more-tags-links-2313527-6.patch2.15 KB

Heres a fix.

k4v’s picture

k4v commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new tagclouds-optionally-hide-more-tags-links-2313527-8.patch2.15 KB

previous patch didn't apply to latest dev same code but hashmarks and line numbers updated.

Try this one instead.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new tagclouds-optionally-hide-more-tags-links-2313527-9.patch2.41 KB

Thanks for the updates guys, but in the #6 patch, you forgot to save the newly introduced 'more_link' variable value. I've fixed this issue with this patch.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new tagclouds-optionally-hide-more-tags-links-2313527-10.patch2.42 KB

Updated my previous patch for the latest dev.

  • mxr576 authored 3d51d96 on 7.x-1.x 
    Issue #2313527 by mxr576, k4v, joseph.olstad: Optionally hide more links
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

mxr576, I've committed your change and granted you maintainer access for tagclouds. Keep up the good work.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed
mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented

Thank you joseph.olstad!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.