I have installed the Markdowneditor for BUEditor and when enabled, all of the icons are not shown for bueditor.

On inspection of the code, I can see that the icons image src is incorrect with an additional '.' dot symbol before the '@2x.png' part of image png:

Incorrect:

<input type="image" alt="Format selected text as code" title="Format selected text as code" accesskey="" id="bue-1-button-3" class="bue-button bue-image-button editor-image-button" src="/sites/all/modules/markdowneditor/icons/md-make-code.@2x.png" <tabindex="-1">

Should be (note the removal of the dot before the @2x.png):

<input type="image" alt="Format selected text as code" title="Format selected text as code" accesskey="" id="bue-1-button-3" class="bue-button bue-image-button editor-image-button" src="/sites/all/modules/markdowneditor/icons/md-make-code@2x.png" tabindex="-1">

I have made a workaround of renaming the icons filenames in 'sites/all/modules/markdowneditor' for my site, but I suspect the better solution is to fix the source code to remove the extra dot.

Comments

Dezra’s picture

Assigned: Unassigned » Dezra

I am making a patch for the two files to remove the '.'.

Files are:

bueditor.buttons.txt
markdowneditor.buttons.inc

Dezra’s picture

Status: Active » Needs review
StatusFileSize
new5.91 KB

Patch attached: removes the extra dots from the two files (bueditor.buttons.txt and markdowneditor.buttons.inc) in the markdowneditor directory.

However I am having issues getting the editor to use the new files. Could someone suggest the correct place/command to make the module update to use new values? Im guessing Im missing a LESS compile phase somewhere (as file is inc).

Dezra’s picture

StatusFileSize
new10.07 KB

Updated patch to be inline with drupal patching procedure.

After deleting the module and reinstalling it (with patch applied). My patch fixes the issue and the icons can be seen again in the wysiwig editor bar.

  • frjo committed a2e0659 on 7.x-1.x authored by Dezra
    Issue #2292583 by Dezra: Fixed BUEditor icons are not found due to extra...
frjo’s picture

Status: Needs review » Fixed

Thanks you for contributing a patch to fix my silly search and replace mistake!

I have committed your patch and made a new 7.x-1.4 release that should show up as soon as the build scripts on d.o. has done there bit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dezra’s picture

No problem frjo, I'm glad to help. The bueditor is very good (I'm using it on my personal blog)