Changes:

  • Add blank line after last @param in function block.
  • Add comma after last multiline array item.
  • Correct @param type "boolean" to "bool".
  • Remove parentheses from include_once statement.
  • Wrap or shorten excessively long comment lines.

These are fixes I think people would be unlikely to disagree with as a matter of style. The patch does not fix all Drupal coding standards issues identified by Coder Review. (Though I wouldn't mind developing a further patch that fixes them all.) Most of the remaining Coder Review warnings were for not ending comments with full stops (e.g., periods).

CommentFileSizeAuthor
#1 browscap-coding_standards_fixes-2290475-1.patch3.83 KBaohrvetpv
browscap-coding_standards_fixes.patch3.56 KBaohrvetpv

Comments

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new browscap-coding_standards_fixes-2290475-1.patch3.83 KB

Changes from previous patch:

  • Correct hook_schema() function comment.

  • greggles committed 91a76c8 on 7.x-2.x 
    Issue #2290475 by AohRveTPV, greggles: coding standards fixes

  • greggles committed 7398890 on 
    Issue #2290475 by AohRveTPV, greggles: coding standards fixes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

I fixed all the issues with end of line and an array longer than 80 chars issue. All good now - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.